linux-kernel - Re: [PATCH v2] efi: libstub: add support for the apple_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZoJAAifMqIDXdniv@wunner.de>
Date: Mon, 1 Jul 2024 07:34:58 +0200
From: Lukas Wunner <lukas@...ner.de>
To: Aditya Garg <gargaditya08@...e.com>
Cc: Ard Biesheuvel <ardb@...nel.org>, Hans de Goede <hdegoede@...hat.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>,
	Kerem Karabay <kekrby@...il.com>,
	Orlando Chamberlain <orlandoch.dev@...il.com>
Subject: Re: [PATCH v2] efi: libstub: add support for the apple_set_os
 protocol

On Sun, Jun 30, 2024 at 07:24:54PM +0000, Aditya Garg wrote:
> @@ -335,9 +359,12 @@ static const efi_char16_t apple[] = L"Apple";
>  
>  static void setup_quirks(struct boot_params *boot_params)
>  {
> -	if (IS_ENABLED(CONFIG_APPLE_PROPERTIES) &&
> -	    !memcmp(efistub_fw_vendor(), apple, sizeof(apple)))
> -		retrieve_apple_device_properties(boot_params);
> +	if (!memcmp(efistub_fw_vendor(), apple, sizeof(apple))) {
> +		if (IS_ENABLED(CONFIG_APPLE_PROPERTIES)) {
> +			retrieve_apple_device_properties(boot_params);
> +		}
> +		apple_set_os();
> +	}

Nit: Unnecessary curly braces around retrieve_apple_device_properties().

(And I'd appreciate a blank line between it and the apple_set_os() call.