linux-kernel - Re: [PATCH v2 1/4] Add generic functions for accessing the SPI-NOR chip.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <93a088d6-8092-43d7-953a-5374a22ac6eb@linaro.org>
Date: Mon, 1 Jul 2024 06:28:17 +0100
From: Tudor Ambarus <tudor.ambarus@...aro.org>
To: Erez Geva <erezgeva@...ime.org>, linux-mtd@...ts.infradead.org,
 Pratyush Yadav <pratyush@...nel.org>, Michael Walle <mwalle@...nel.org>
Cc: linux-kernel@...r.kernel.org, Miquel Raynal <miquel.raynal@...tlin.com>,
 Richard Weinberger <richard@....at>, Vignesh Raghavendra <vigneshr@...com>,
 devicetree@...r.kernel.org, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Erez Geva <ErezGeva2@...il.com>
Subject: Re: [PATCH v2 1/4] Add generic functions for accessing the SPI-NOR
 chip.

On 6/29/24 11:39 AM, Erez Geva wrote:
> From: Erez Geva <ErezGeva2@...il.com>
> 
> Functions:
> 
>  - Send an opcode
> 
>  - Read a register
> 
>  - Write a register

Don't use the commit message as a continuation of the subject. Describe
your changes. Convince the reviewer why you need to change core methods
and that it makes sense for them to read past the first paragraph.

You ignored the feedback from v1, I'm marking this as changes requested
and ignore the rest.