linux-kernel - Re: [PATCH] media: imx-pxp: Rewrite coeff expression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7dbda1952c9e873823d4e6d2a9534f1b3b945c4a.camel@pengutronix.de>
Date: Mon, 01 Jul 2024 11:30:28 +0200
From: Philipp Zabel <p.zabel@...gutronix.de>
To: Ricardo Ribalda <ribalda@...omium.org>, Mauro Carvalho Chehab
 <mchehab@...nel.org>, Shawn Guo <shawnguo@...nel.org>, Sascha Hauer
 <s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>, 
 Fabio Estevam <festevam@...il.com>
Cc: linux-media@...r.kernel.org, imx@...ts.linux.dev, 
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, Hans
 Verkuil <hverkuil-cisco@...all.nl>
Subject: Re: [PATCH] media: imx-pxp: Rewrite coeff expression

On Fr, 2024-06-28 at 15:11 +0000, Ricardo Ribalda wrote:
> GCC5 cannot figure out that the expressions are constant, and that
> triggers a build failure. Rewrite the expressions.
> 
> The following gcc5 error is workaround:
> 
>  #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000
>                                       ^
>     BM_PXP_CSC1_COEF0_YCBCR_MODE |
>     ^
>  #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000
>                                       ^
> 
> drivers/media/platform/nxp/imx-pxp.c: In function 'pxp_setup_csc':
> drivers/media/platform/nxp/imx-pxp.h:582:38: error: initializer element is not constant
> drivers/media/platform/nxp/imx-pxp.c:374:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE'
> drivers/media/platform/nxp/imx-pxp.h:582:38: note: (near initialization for 'csc1_coef_bt601_lim[0]')
> Signed-off-by: Ricardo Ribalda <ribalda@...omium.org>

Can you elaborate on how this is triggered?

At least I couldn't reproduce this by just copy & pasting the
csc1_coef_bt601_lim initializer and the required macros into gcc 5.4 on
godbolt.

Can this be fixed by using GENMASK / FIELD_PREP instead?

regards
Philipp