linux-kernel - Re: [PATCH] Drivers: hv: vmbus: Add missing check for dma_set_mask in vmbus_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6e5dffe8-69fa-4d91-8cf1-136265bb5500@web.de>
Date: Mon, 1 Jul 2024 11:30:32 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Haoxiang Li <make24@...as.ac.cn>, linux-hyperv@...r.kernel.org,
 kernel-janitors@...r.kernel.org, Andrea Parri <parri.andrea@...il.com>,
 Dexuan Cui <decui@...rosoft.com>, Haiyang Zhang <haiyangz@...rosoft.com>,
 "K. Y. Srinivasan" <kys@...rosoft.com>,
 Michael Kelley <mikelley@...rosoft.com>, Wei Liu <wei.liu@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Drivers: hv: vmbus: Add missing check for dma_set_mask in
 vmbus_device_register()

> child_device_obj->device cannot perform DMA properly if dma_set_mask()
> returns non-zero. …

Another wording suggestion:
  Direct memory access can not be properly performed any more
  after a dma_set_mask() call failed.

See also:
https://elixir.bootlin.com/linux/v6.10-rc6/source/kernel/dma/mapping.c#L804

>      … child_device_obj->device is not initialized here, so use kfree() to
> free child_device_obj->device.

How did you come to the conclusion that meaningful data processing
would still be possible according to such information?

…
> Signed-off-by: Haoxiang Li <make24@...as.ac.cn>

I find it interesting that another personal name is presented here.
I noticed that some patches were published with the name “Ma Ke” previously.
How will requirements be resolved for the Developer's Certificate of Origin?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc6#n398

Would you like to append parentheses to another function name in the summary phrase?

Regards,
Markus