linux-kernel - Re: [PATCH v2 3/4] dt-bindings: mtd: macronix,mx25l12833f: add SPI-NOR chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANeKEMO42rJt5Ob4_HDcZ3eEMvuMOPvRaFaLwL8SA65NtxSV7A@mail.gmail.com>
Date: Mon, 1 Jul 2024 11:46:18 +0200
From: Erez <erezgeva2@...il.com>
To: Tudor Ambarus <tudor.ambarus@...aro.org>
Cc: Erez Geva <erezgeva@...ime.org>, linux-mtd@...ts.infradead.org, 
	Pratyush Yadav <pratyush@...nel.org>, Michael Walle <mwalle@...nel.org>, linux-kernel@...r.kernel.org, 
	Miquel Raynal <miquel.raynal@...tlin.com>, Richard Weinberger <richard@....at>, 
	Vignesh Raghavendra <vigneshr@...com>, devicetree@...r.kernel.org, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Subject: Re: [PATCH v2 3/4] dt-bindings: mtd: macronix,mx25l12833f: add
 SPI-NOR chip

Sorry, I resend the same mail, as I send it again as HTML.

How?

When using mx25l12805d, we do not read SFDP.
As it uses the no-SFDP flags.
When using mx25l12833f hardware with mx25l12805d driver, it did not
try to read the SFDP.
Yet mx25l12833f does have SFDP, when I remove the no-SFDP flags, the
driver fetch the SFDP.

Secondly SFDP does not contain OTP information.

mx25l12805d has two OTP regions of 128 KiB and 384 KiB (yes asymmetric).
While mx25l12833f has two OTP regions of 512 KiB.

How do we handle it?
I would gladly remove the obsolete mx25l12805d.
And skp compatibles all together.

Thanks
    Erez Geva




On Mon, 1 Jul 2024 at 11:40, Erez <erezgeva2@...il.com> wrote:
>
> How?
>
> When using mx25l12805d, we do not read SFDP.
> As it uses the no-SFDP flags.
> When using mx25l12833f hardware with mx25l12805d driver, it did not try to read the SFDP.
> Yet mx25l12833f does have SFDP, when I remove the no-SFDP flags, the driver fetch the SFDP.
>
> Secondly SFDP does not contain OTP information.
>
> mx25l12805d has two OTP regions of 128 KiB and 384 KiB (yes asymmetric).
> While mx25l12833f has two OTP regions of 512 KiB.
>
> How do we handle it?
> I would gladly remove the obsolete mx25l12805d.
> And skp compatibles all together.
>
> Thanks
>     Erez Geva
>
>
>
>
>
> On Mon, 1 Jul 2024 at 07:23, Tudor Ambarus <tudor.ambarus@...aro.org> wrote:
>>
>> Hi,
>>
>> On 6/29/24 11:39 AM, Erez Geva wrote:
>> > From: Erez Geva <ErezGeva2@...il.com>
>> >
>> > Add Macronix SPI-NOR mx25l12833f.
>> >
>> > mx25l12833f uses the same JEDEC ID as mx25l12805d.
>> >
>> > Although mx25l12833f is a new chip that support read ID and SFDP,
>> >  users might want to specify it in the device tree,
>> >  to differ it from the old mx25l12805d chip.
>>
>> As Michael said in a reply in v1, we try really hard to don't introduce
>> new compatibles and instead rely on the generic "jedec,spi-nor". In your
>> case you can differentiate between the two flavors of flashes based on
>> the SFDP presence. We won't apply this.
>>
>> Cheers,
>> ta