linux-kernel - Re: [PATCH v10 07/24] virt: sev-guest: Store VMPCK index to SNP guest device structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <007c2e93-d5cd-7f7e-bd29-bfc0da4c18ba@amd.com>
Date: Mon, 1 Jul 2024 16:15:31 +0530
From: "Nikunj A. Dadhania" <nikunj@....com>
To: Borislav Petkov <bp@...en8.de>
Cc: linux-kernel@...r.kernel.org, thomas.lendacky@....com, x86@...nel.org,
 kvm@...r.kernel.org, mingo@...hat.com, tglx@...utronix.de,
 dave.hansen@...ux.intel.com, pgonda@...gle.com, seanjc@...gle.com,
 pbonzini@...hat.com
Subject: Re: [PATCH v10 07/24] virt: sev-guest: Store VMPCK index to SNP guest
 device structure

On 6/28/2024 9:22 AM, Borislav Petkov wrote:
> On Fri, Jun 21, 2024 at 06:08:46PM +0530, Nikunj A Dadhania wrote:
>> Currently, SEV guest driver retrieves the pointers to VMPCK and
>> os_area_msg_seqno from the secrets page. In order to get rid of this
>> dependency,
> 
> And we do this because...?

Thinking more about this patch, I think I can drop this patch and retain
the VMPCK pointer and the os_area_msg_seqno.

In my v8 [1] and earlier series, I had dropped secrets pages pointer from
snp_guest_dev structure. But with newer changes in v9 secrets pages pointer
is retained so all these APIs will still be fine. 

> 
>> use vmpck_id to index the appropriate key and the corresponding
>> message sequence number.
>>
>> Signed-off-by: Nikunj A Dadhania <nikunj@....com>

Regards
Nikunj

1. https://lore.kernel.org/lkml/20240215113128.275608-8-nikunj@amd.com/