linux-kernel - Re: [PATCH v10 07/24] virt: sev-guest: Store VMPCK index to SNP guest device structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240701124127.GEZoKj952TjNCZ8NiN@fat_crate.local>
Date: Mon, 1 Jul 2024 14:41:27 +0200
From: Borislav Petkov <bp@...en8.de>
To: "Nikunj A. Dadhania" <nikunj@....com>
Cc: linux-kernel@...r.kernel.org, thomas.lendacky@....com, x86@...nel.org,
	kvm@...r.kernel.org, mingo@...hat.com, tglx@...utronix.de,
	dave.hansen@...ux.intel.com, pgonda@...gle.com, seanjc@...gle.com,
	pbonzini@...hat.com
Subject: Re: [PATCH v10 07/24] virt: sev-guest: Store VMPCK index to SNP
 guest device structure

On Mon, Jul 01, 2024 at 04:15:31PM +0530, Nikunj A. Dadhania wrote:
> In my v8 [1] and earlier series, I had dropped secrets pages pointer from
> snp_guest_dev structure. But with newer changes in v9 secrets pages pointer
> is retained so all these APIs will still be fine. 

So I think you should step back, get a pen and paper and think about the
design of what is going to be exported from sev.c to sev-guest, write it down
and run it by folks first before you go code.

Because right now it feels like a waste of time for everybody involved.
I still have no clue what is going on - just a rough idea.

Also, looking forward:

Subject: [PATCH v10 13/24] x86/sev: Make sev-guest driver functional again

That's a no-no.

You can't have a broken kernel at some point in the patch series. Unless you
can't really avoid it. And I don't think there's a problem here: you define
the interfaces and switch sev-guest to them in one last patch.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette