linux-kernel - Re: [PATCH v2 -next] cgroup/rstat: add force idle show helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 2 Jul 2024 07:19:50 -1000
From: Tejun Heo <tj@...nel.org>
To: Chen Ridong <chenridong@...wei.com>
Cc: lizefan.x@...edance.com, hannes@...xchg.org, longman@...hat.com,
	cgroups@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 -next] cgroup/rstat: add force idle show helper

Hello,

On Tue, Jul 02, 2024 at 02:28:22AM +0000, Chen Ridong wrote:
...
>  	if (cgroup_parent(cgrp)) {
>  		cgroup_rstat_flush_hold(cgrp);
>  		usage = cgrp->bstat.cputime.sum_exec_runtime;
>  		cputime_adjust(&cgrp->bstat.cputime, &cgrp->prev_cputime,
>  			       &utime, &stime);
> -#ifdef CONFIG_SCHED_CORE
> -		forceidle_time = cgrp->bstat.forceidle_sum;
> -#endif
> +		bstat = cgrp->bstat;

Please don't copy non-trivial struct like this. Maybe add a pointer which
points to the bstat to use?

Thanks.

-- 
tejun