linux-kernel - Re: [Patch v6] i2c: pnx: Fix potential deadlock warning from del_timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 2 Jul 2024 11:13:06 +0200
From: Piotr Wojtaszczyk <piotr.wojtaszczyk@...esys.com>
To: Andi Shyti <andi.shyti@...nel.org>
Cc: Vladimir Zapolskiy <vz@...ia.com>, linux-arm-kernel@...ts.infradead.org, 
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [Patch v6] i2c: pnx: Fix potential deadlock warning from
 del_timer_sync() call in isr

On Tue, Jul 2, 2024 at 1:01 AM Andi Shyti <andi.shyti@...nel.org> wrote:
> > @@ -653,7 +624,10 @@ static int i2c_pnx_probe(struct platform_device *pdev)
> >       alg_data->adapter.algo_data = alg_data;
> >       alg_data->adapter.nr = pdev->id;
> >
> > -     alg_data->timeout = I2C_PNX_TIMEOUT_DEFAULT;
> > +     alg_data->timeout = msecs_to_jiffies(I2C_PNX_TIMEOUT_DEFAULT);
> > +     if (alg_data->timeout <= 1)
> > +             alg_data->timeout = 2;
>
> I don't see the need for this check. The default timeout is
> defined as 10.
>
> Thanks,
> Andi

That's the timeout value which was in the previous timer in i2c_pnx_arm_timer(),
without this I had time out events.


-- 
Piotr Wojtaszczyk
Timesys