linux-kernel - Re: [PATCH V5 4/7] dt-bindings: clock: Add ipq9574 NSSCC clock and reset definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 2 Jul 2024 17:43:08 +0530
From: Devi Priya <quic_devipriy@...cinc.com>
To: "Rob Herring (Arm)" <robh@...nel.org>
CC: <catalin.marinas@....com>, <u-kumar1@...com>,
        <linux-arm-kernel@...ts.infradead.org>, <krzk+dt@...nel.org>,
        <geert+renesas@...der.be>, <neil.armstrong@...aro.org>,
        <nfraprado@...labora.com>, <mturquette@...libre.com>,
        <linux-kernel@...r.kernel.org>, <dmitry.baryshkov@...aro.org>,
        <netdev@...r.kernel.org>, <konrad.dybcio@...aro.org>,
        <m.szyprowski@...sung.com>, <arnd@...db.de>,
        <richardcochran@...il.com>, <will@...nel.org>, <sboyd@...nel.org>,
        <andersson@...nel.org>, <p.zabel@...gutronix.de>,
        <linux-clk@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <conor+dt@...nel.org>, <linux-arm-msm@...r.kernel.org>
Subject: Re: [PATCH V5 4/7] dt-bindings: clock: Add ipq9574 NSSCC clock and
 reset definitions



On 6/26/2024 9:05 PM, Rob Herring (Arm) wrote:
> 
> On Wed, 26 Jun 2024 20:02:59 +0530, Devi Priya wrote:
>> Add NSSCC clock and reset definitions for ipq9574.
>>
>> Signed-off-by: Devi Priya <quic_devipriy@...cinc.com>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>> ---
>>   Changes in V5:
>> 	- Dropped interconnects and added interconnect-cells to NSS
>> 	  clock provider so that it can be  used as icc provider.
>>
>>   .../bindings/clock/qcom,ipq9574-nsscc.yaml    |  74 +++++++++
>>   .../dt-bindings/clock/qcom,ipq9574-nsscc.h    | 152 ++++++++++++++++++
>>   .../dt-bindings/reset/qcom,ipq9574-nsscc.h    | 134 +++++++++++++++
>>   3 files changed, 360 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml
>>   create mode 100644 include/dt-bindings/clock/qcom,ipq9574-nsscc.h
>>   create mode 100644 include/dt-bindings/reset/qcom,ipq9574-nsscc.h
>>
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> Error: Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.example.dts:26.26-27 syntax error
> FATAL ERROR: Unable to parse input tree
> make[2]: *** [scripts/Makefile.lib:427: Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.example.dtb] Error 1
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1430: dt_binding_check] Error 2
> make: *** [Makefile:240: __sub-make] Error 2
> 
> doc reference errors (make refcheckdocs):
> 
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240626143302.810632-5-quic_devipriy@quicinc.com
> 
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
> Hi Rob,

We tried running dt_binding_check on linux-next and we do not face any
sort of errors.

However in case of v6.10-rc1, patch[1] failed to apply as the dependent
patch[2] is not available on rc1.

[1] 
https://patchwork.kernel.org/project/linux-arm-msm/patch/20240626143302.810632-3-quic_devipriy@quicinc.com/

[2] 
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20240531&id=475beea0b9f631656b5cc39429a39696876af613

Patch [2] does not hold any functional dependency on this series but has 
a patch rebase dependency.

The Bot has went ahead and tried running the dt_binding_check on patch 
https://patchwork.kernel.org/project/linux-arm-msm/patch/20240626143302.810632-5-quic_devipriy@quicinc.com/
which is dependent on patch [1] and hence the issue was reported.

Is this the expected behaviour?

Thanks & Regards,
Devi Priya
>