linux-kernel - Re: [PATCH] selinux: Use 1UL for EBITMAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d5b7485edf9a4cdbc85b6b191b00e572@paul-moore.com>
Date: Tue, 02 Jul 2024 11:41:04 -0400
From: Paul Moore <paul@...l-moore.com>
To: Canfeng Guo <guocanfeng@...ontech.com>
Cc: stephen.smalley.work@...il.com, omosnace@...hat.com, selinux@...r.kernel.org, linux-kernel@...r.kernel.org, Canfeng Guo <guocanfeng@...ontech.com>
Subject: Re: [PATCH] selinux: Use 1UL for EBITMAP_BIT to match maps type

On Jun 29, 2024 Canfeng Guo <guocanfeng@...ontech.com> wrote:
> 
> This patch modifies the definition of EBITMAP_BIT in
> security/selinux/ss/ebitmap.h from 1ULL to 1UL to match the type
> of elements in the ebitmap_node maps array.
> 
> This change does not affect the functionality or correctness of
> the code but aims to enhance code quality by adhering to good
> programming practices and avoiding unnecessary type conversions.
> 
> Signed-off-by: Canfeng Guo <guocanfeng@...ontech.com>
> ---
>  security/selinux/ss/ebitmap.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, this looks good to me, and it's trivial enough that I think it
is safe to merge at this point in the release cycle; merged to
selinux/dev.

--
paul-moore.com