[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c76yhzs4psywaqes32zb23ixbujejurn3f3hj3qswbzaxf3j25@2wslykbylak4>
Date: Tue, 2 Jul 2024 22:08:27 -0500
From: Bjorn Andersson <andersson@...nel.org>
To: Jagadeesh Kona <quic_jkona@...cinc.com>
Cc: Michael Turquette <mturquette@...libre.com>,
Stephen Boyd <sboyd@...nel.org>, Stanimir Varbanov <stanimir.k.varbanov@...il.com>,
Vikash Garodia <quic_vgarodia@...cinc.com>, Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
Mauro Carvalho Chehab <mchehab@...nel.org>, Ulf Hansson <ulf.hansson@...aro.org>,
"Rafael J . Wysocki" <rafael@...nel.org>, Kevin Hilman <khilman@...nel.org>, Pavel Machek <pavel@....cz>,
Len Brown <len.brown@...el.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>, Andy Gross <agross@...nel.org>,
Dmitry Baryshkov <dmitry.baryshkov@...aro.org>, Abel Vesa <abel.vesa@...aro.org>, linux-pm@...r.kernel.org,
linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
linux-kernel@...r.kernel.org, Taniya Das <quic_tdas@...cinc.com>,
Satya Priya Kakitapalli <quic_skakitap@...cinc.com>, Imran Shaik <quic_imrashai@...cinc.com>,
Ajit Pandey <quic_ajipan@...cinc.com>
Subject: Re: [PATCH V7 4/5] clk: qcom: videocc: Use HW_CTRL_TRIGGER for
SM8250, SC7280 vcodec GDSC's
On Mon, Jun 24, 2024 at 10:18:08AM GMT, Jagadeesh Kona wrote:
> For Venus V6 variant SoCs(sm8250, sc7280), the venus driver uses the newly
> introduced dev_pm_genpd_set_hwmode() API to switch the vcodec GDSC to
> HW/SW control modes at runtime. Hence use HW_CTRL_TRIGGER flag for vcodec
> GDSC's on sm8250, sc7280 to register the set_hwmode_dev & get_hwmode_dev
> callbacks for vcodec GDSC and allow the GDSC mode to be changed using
> dev_pm_genpd_set_hwmode() API.
>
> Signed-off-by: Jagadeesh Kona <quic_jkona@...cinc.com>
> Signed-off-by: Abel Vesa <abel.vesa@...aro.org>
> Reviewed-by: Taniya Das <quic_tdas@...cinc.com>
Acked-by: Bjorn Andersson <andersson@...nel.org>
Regards,
Bjorn
> ---
> drivers/clk/qcom/videocc-sc7280.c | 2 +-
> drivers/clk/qcom/videocc-sm8250.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/clk/qcom/videocc-sc7280.c b/drivers/clk/qcom/videocc-sc7280.c
> index 317b325d6daf..88c90853cf6e 100644
> --- a/drivers/clk/qcom/videocc-sc7280.c
> +++ b/drivers/clk/qcom/videocc-sc7280.c
> @@ -240,7 +240,7 @@ static struct gdsc mvs0_gdsc = {
> .name = "mvs0_gdsc",
> },
> .pwrsts = PWRSTS_OFF_ON,
> - .flags = HW_CTRL | RETAIN_FF_ENABLE,
> + .flags = HW_CTRL_TRIGGER | RETAIN_FF_ENABLE,
> };
>
> static struct gdsc mvsc_gdsc = {
> diff --git a/drivers/clk/qcom/videocc-sm8250.c b/drivers/clk/qcom/videocc-sm8250.c
> index d7e0c32284c1..df479a69cddd 100644
> --- a/drivers/clk/qcom/videocc-sm8250.c
> +++ b/drivers/clk/qcom/videocc-sm8250.c
> @@ -293,7 +293,7 @@ static struct gdsc mvs0_gdsc = {
> .pd = {
> .name = "mvs0_gdsc",
> },
> - .flags = HW_CTRL,
> + .flags = HW_CTRL_TRIGGER,
> .pwrsts = PWRSTS_OFF_ON,
> };
>
> @@ -302,7 +302,7 @@ static struct gdsc mvs1_gdsc = {
> .pd = {
> .name = "mvs1_gdsc",
> },
> - .flags = HW_CTRL,
> + .flags = HW_CTRL_TRIGGER,
> .pwrsts = PWRSTS_OFF_ON,
> };
>
> --
> 2.43.0
>
Powered by blists - more mailing lists