linux-kernel - Re: [PATCH v5 -next] cgroup/misc: Introduce misc.peak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZoWSVBVAbQjW0l34@slm.duckdns.org>
Date: Wed, 3 Jul 2024 08:03:00 -1000
From: Tejun Heo <tj@...nel.org>
To: Kamalesh Babulal <kamalesh.babulal@...cle.com>
Cc: Xiu Jianfeng <xiujianfeng@...wei.com>, lizefan.x@...edance.com,
	hannes@...xchg.org, corbet@....net, haitao.huang@...ux.intel.com,
	cgroups@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 -next] cgroup/misc: Introduce misc.peak

On Wed, Jul 03, 2024 at 03:13:29PM +0530, Kamalesh Babulal wrote:
...
> The patch looks good to me after the atomic conversion. Sorry for bringing up
> this question so late into the discussion. Given that misc.max is available
> only for non-root cgroups,  does it make sense for misc.peak too, available
> for non-root cgroups only?

It's more tied to the usage - misc.current. For memcg, memory.current is
only on non-root cgroups, so is peak. For misc, as misc.current exists for
the root cgroup, it makes sense for .peak to be there too.

Thanks.

-- 
tejun