linux-kernel - Re: [PATCH v5 -next] cgroup/misc: Introduce misc.peak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cb6bc4b9-bbf3-4d43-aeb8-8efdcbf94a9c@oracle.com>
Date: Wed, 3 Jul 2024 15:13:29 +0530
From: Kamalesh Babulal <kamalesh.babulal@...cle.com>
To: Xiu Jianfeng <xiujianfeng@...wei.com>, tj@...nel.org,
        lizefan.x@...edance.com, hannes@...xchg.org, corbet@....net,
        haitao.huang@...ux.intel.com
Cc: cgroups@...r.kernel.org, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 -next] cgroup/misc: Introduce misc.peak



On 7/3/24 6:06 AM, Xiu Jianfeng wrote:
> Introduce misc.peak to record the historical maximum usage of the
> resource, as in some scenarios the value of misc.max could be
> adjusted based on the peak usage of the resource.
> 

[...]

>  /**
>   * misc_cg_capacity_show() - Show the total capacity of misc res on the host.
>   * @sf: Interface file
> @@ -357,6 +394,10 @@ static struct cftype misc_cg_files[] = {
>  		.name = "current",
>  		.seq_show = misc_cg_current_show,
>  	},
> +	{
> +		.name = "peak",
> +		.seq_show = misc_cg_peak_show,
> +	},
>  	{
>  		.name = "capacity",
>  		.seq_show = misc_cg_capacity_show,


The patch looks good to me after the atomic conversion. Sorry for bringing up
this question so late into the discussion. Given that misc.max is available
only for non-root cgroups,  does it make sense for misc.peak too, available
for non-root cgroups only?

-- 
Thanks,
Kamalesh