linux-kernel - Re: [PATCH 1/2] sched/uclamp: Delegate uclamp to each sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZoWUyrYwVDqSMBam@slm.duckdns.org>
Date: Wed, 3 Jul 2024 08:13:30 -1000
From: Tejun Heo <tj@...nel.org>
To: Hongyan Xia <hongyan.xia2@....com>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] sched/uclamp: Delegate uclamp to each sched_class

On Wed, Jul 03, 2024 at 11:07:47AM +0100, Hongyan Xia wrote:
> uclamp-related operations are written in core.c in a way that may
> suggest it is a global thing regardless of sched_class, but we end up
> checking sched_class->uclamp_enabled, so in reality it is sched_class
> specific anyway.
> 
> Remove sched_class->uclamp_enabled and simply delegate uclamp to
> sched_class->{enqueue,dequeue}_task(). This also removes extra
> uclamp_enabled checks in uclamp_rq_{inc,dec}().
> 
> No functional changes for fair and RT.
> 
> Signed-off-by: Hongyan Xia <hongyan.xia2@....com>

Acked-by: Tejun Heo <tj@...nel.org>

Thanks.

-- 
tejun