linux-kernel - Re: [PATCH net-next v2 2/3] net: dsa: microchip: lan937x: disable in-band status support for RGMII interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c3bd53402133e727bb34b6655d62fc2d472e2ede.camel@microchip.com>
Date: Wed, 3 Jul 2024 03:09:33 +0000
From: <Arun.Ramadoss@...rochip.com>
To: <andrew@...n.ch>, <olteanv@...il.com>, <davem@...emloft.net>,
	<Woojung.Huh@...rochip.com>, <pabeni@...hat.com>, <o.rempel@...gutronix.de>,
	<edumazet@...gle.com>, <f.fainelli@...il.com>, <kuba@...nel.org>
CC: <l.stach@...gutronix.de>, <kernel@...gutronix.de>,
	<linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
	<UNGLinuxDriver@...rochip.com>
Subject: Re: [PATCH net-next v2 2/3] net: dsa: microchip: lan937x: disable
 in-band status support for RGMII interfaces

Hi Oleksij,
On Mon, 2024-07-01 at 10:53 +0200, Oleksij Rempel wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
> 
> From: Lucas Stach <l.stach@...gutronix.de>
> 
> This driver do not support in-band mode and in case of CPU<->Switch
> link, this mode is not working any way. So, disable it otherwise
> ingress
> path of the switch MAC will stay disabled.
> 
> Note: lan9372 manual do not document 0xN301 BIT(2) for the RGMII mode
> and recommend[1] to disable in-band link status update for the RGMII
> RX
> path by clearing 0xN302 BIT(0).
>  But, 0xN301 BIT(2) seems to work too, so
> keep it unified with other KSZ switches.
> 
> [1] 
> https://microchip.my.site.com/s/article/LAN937X-The-required-configuration-for-the-external-MAC-port-to-operate-at-RGMII-to-RGMII-1Gbps-link-speed
> 
> Signed-off-by: Lucas Stach <l.stach@...gutronix.de>
> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>

But If you want IBS to be enabled, then we need to set both the bit
0xN301 BIT(2) and 0xN302 BIT(0).

Acked-by: Arun Ramadoss <arun.ramadoss@...rochip.com>