linux-kernel - Re: [PATCH net-next v2 3/3] net: dsa: microchip: lan937x: disable VPHY support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d147c4363c778c6c94f849c0be0996fa8695fdd0.camel@microchip.com>
Date: Wed, 3 Jul 2024 03:15:06 +0000
From: <Arun.Ramadoss@...rochip.com>
To: <andrew@...n.ch>, <olteanv@...il.com>, <davem@...emloft.net>,
	<Woojung.Huh@...rochip.com>, <pabeni@...hat.com>, <o.rempel@...gutronix.de>,
	<edumazet@...gle.com>, <f.fainelli@...il.com>, <kuba@...nel.org>
CC: <l.stach@...gutronix.de>, <kernel@...gutronix.de>,
	<linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
	<UNGLinuxDriver@...rochip.com>
Subject: Re: [PATCH net-next v2 3/3] net: dsa: microchip: lan937x: disable
 VPHY support

Hi Oleksij,


> ---
>  drivers/net/dsa/microchip/lan937x_main.c | 3 +++
>  drivers/net/dsa/microchip/lan937x_reg.h  | 4 ++++
>  2 files changed, 7 insertions(+)
> 
> diff --git a/drivers/net/dsa/microchip/lan937x_main.c
> b/drivers/net/dsa/microchip/lan937x_main.c
> index eaa862eb6b265..0606796b14856 100644
> --- a/drivers/net/dsa/microchip/lan937x_main.c
> +++ b/drivers/net/dsa/microchip/lan937x_main.c
> @@ -390,6 +390,9 @@ int lan937x_setup(struct dsa_switch *ds)
>         lan937x_cfg(dev, REG_SW_GLOBAL_OUTPUT_CTRL__1,
>                     (SW_CLK125_ENB | SW_CLK25_ENB), true);
> 
> +       /* Disable global VPHY support. Related to CPU interface
> only? */
> +       ksz_rmw32(dev, REG_SW_CFG_STRAP_OVR, SW_VPHY_DISABLE,
> SW_VPHY_DISABLE);

Do we need to check the return value of ksz_rmw32?

> +
>         return 0;
>  }
> 
>