linux-kernel - Re: [PATCH v3] PCI: hv: Return zero, not garbage, when reading PCI_INTERRUPT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZoW-FaSBPPDa8NX9@liuwe-devbox-debian-v2>
Date: Wed, 3 Jul 2024 21:09:41 +0000
From: Wei Liu <wei.liu@...nel.org>
To: Krzysztof Wilczyński <kw@...ux.com>
Cc: Wei Liu <wei.liu@...nel.org>,
	Linux on Hyper-V List <linux-hyperv@...r.kernel.org>,
	stable@...nel.org, Michael Kelley <mhklinux@...look.com>,
	"K. Y. Srinivasan" <kys@...rosoft.com>,
	Haiyang Zhang <haiyangz@...rosoft.com>,
	Dexuan Cui <decui@...rosoft.com>,
	Lorenzo Pieralisi <lpieralisi@...nel.org>,
	Rob Herring <robh@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>,
	Jake Oshins <jakeo@...rosoft.com>,
	"open list:PCI NATIVE HOST BRIDGE AND ENDPOINT DRIVERS" <linux-pci@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] PCI: hv: Return zero, not garbage, when reading
 PCI_INTERRUPT_PIN

On Wed, Jul 03, 2024 at 05:12:47PM +0900, Krzysztof Wilczyński wrote:
> Hello,
> 
> > > The intent of the code snippet is to always return 0 for both
> > > PCI_INTERRUPT_LINE and PCI_INTERRUPT_PIN.
> > > 
> > > The check misses PCI_INTERRUPT_PIN. This patch fixes that.
> > > 
> > > This is discovered by this call in VFIO:
> > > 
> > >     pci_read_config_byte(vdev->pdev, PCI_INTERRUPT_PIN, &pin);
> > > 
> > > The old code does not set *val to 0 because it misses the check for
> > > PCI_INTERRUPT_PIN. Garbage is returned in that case.
> [...]
> > 
> > Bjorn & other PCI maintainers, do you want to pick this up via your
> > tree?
> > 
> > I can pick this up via the hyperv tree if you prefer.
> 
> We will pick this up.  No worries.

Thank you very much!

> 
> 	Krzysztof
>