linux-kernel - Re: [PATCH 1/2] dt-bindings: arm: rockchip: Add Rock 5 ITX board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0d1b1a5fbe97d27ee54513261d77df0e@manjaro.org>
Date: Wed, 03 Jul 2024 23:11:25 +0200
From: Dragan Simic <dsimic@...jaro.org>
To: Heiko Stuebner <heiko@...ech.de>
Cc: robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: arm: rockchip: Add Rock 5 ITX board

Hello Heiko,

Please see a few comments below.

On 2024-07-03 23:05, Heiko Stuebner wrote:
> Add devicetree binding for the Rock 5 ITX board, build around the 
> rk3588.

s/Rock/ROCK/
s/build/built/

> Signed-off-by: Heiko Stuebner <heiko@...ech.de>
> ---
>  Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml
> b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index d2e887415d5dc..7ddb008f52d1a 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -826,6 +826,11 @@ properties:
>            - const: radxa,rock-5b
>            - const: rockchip,rk3588
> 
> +      - description: Radxa ROCK 5ITX

s/5ITX/5 ITX/

> +        items:
> +          - const: radxa,rock-5itx

s/5itx/5-itx/

> +          - const: rockchip,rk3588
> +
>        - description: Radxa ROCK S0
>          items:
>            - const: radxa,rock-s0