linux-kernel - Re: [PATCH v2 2/2] RAS/AMD/ATL: Translate normalized to system physical addresses using PRM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240703224611.GDZoXUs7INLbRM4v1a@fat_crate.local>
Date: Thu, 4 Jul 2024 00:46:11 +0200
From: Borislav Petkov <bp@...en8.de>
To: John Allen <john.allen@....com>
Cc: rafael@...nel.org, lenb@...nel.org, yazen.ghannam@....com,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-edac@...r.kernel.org
Subject: Re: [PATCH v2 2/2] RAS/AMD/ATL: Translate normalized to system
 physical addresses using PRM

On Wed, Jul 03, 2024 at 03:14:53PM -0500, John Allen wrote:
> I'm not sure this works the way we need it to. If ACPI_PRMT is not
> enabled, then the norm to sys translation function will be referenced by
> the base AMD ATL, but will the symbol will not be found since the the
> PRM file doesn't get compiled.

So you don't delete the stub but you put it in the internal.h header:

#ifndef CONFIG_AMD_ATL_PRM
+unsigned long prm_umc_norm_to_sys_addr(u8 socket_id, u64 umc_bank_inst_id, unsigned long addr)
+{
+       return -ENODEV;
+}
+
+#endif

Don't be afraid to grep the tree - there are gazillion examples how stuff like
that is usually done.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette