linux-kernel - Re: [PATCH v2 2/2] RAS/AMD/ATL: Translate normalized to system physical addresses using PRM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZoWxPR+A3xjV1Y/j@AUS-L1-JOHALLEN.amd.com>
Date: Wed, 3 Jul 2024 15:14:53 -0500
From: John Allen <john.allen@....com>
To: Borislav Petkov <bp@...en8.de>
Cc: rafael@...nel.org, lenb@...nel.org, yazen.ghannam@....com,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-edac@...r.kernel.org
Subject: Re: [PATCH v2 2/2] RAS/AMD/ATL: Translate normalized to system
 physical addresses using PRM

On Fri, Jun 28, 2024 at 09:45:22AM +0200, Borislav Petkov wrote:
> On Mon, May 06, 2024 at 05:47:21PM +0000, John Allen wrote:
> > +#include "internal.h"
> > +
> > +#if defined(CONFIG_ACPI_PRMT)
> 
> Instead of that ifdeffery you could do:
> 
> config AMD_ATL_PRM
> 	depends on AMD_ATL && ACPI_PRMT
> 
> and it'll get enabled automatically and then you don't need the empty
> stub either.

I'm not sure this works the way we need it to. If ACPI_PRMT is not
enabled, then the norm to sys translation function will be referenced by
the base AMD ATL, but will the symbol will not be found since the the
PRM file doesn't get compiled.

I added the AMD_ATL_PRM config and added the following to the ATL
Makefile:
amd_atl-$(CONFIG_AMD_ATL_PRM) += prm.o

instead of:

amd_atl-y		+= prm.o

Is there another way you had in mind to make the additional config
option work as expected?

Thanks,
John