linux-kernel - Re: [PATCH 01/10] MIPS: smp: Make IPI interrupts scalable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <7a822a33-dd67-4827-bbd0-01e75e203951@app.fastmail.com>
Date: Thu, 04 Jul 2024 04:15:21 +0800
From: "Jiaxun Yang" <jiaxun.yang@...goat.com>
To: "Thomas Bogendoerfer" <tsbogend@...ha.franken.de>
Cc: "Florian Fainelli" <florian.fainelli@...adcom.com>,
 "Broadcom internal kernel review list" <bcm-kernel-feedback-list@...adcom.com>,
 "Huacai Chen" <chenhuacai@...nel.org>,
 "Thomas Gleixner" <tglx@...utronix.de>,
 "Serge Semin" <fancer.lancer@...il.com>,
 "paulburton@...nel.org" <paulburton@...nel.org>,
 "linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/10] MIPS: smp: Make IPI interrupts scalable



在2024年7月3日七月 下午11:04，Thomas Bogendoerfer写道：
> On Sun, Jun 16, 2024 at 10:03:05PM +0100, Jiaxun Yang wrote:
>> Define enum ipi_message_type as other architectures did to
>> allow easy extension to number of IPI interrupts, fiddle
>> around platform IPI code to adopt to the new infra, add
>> extensive BUILD_BUG_ON on IPI numbers to ensure future
>> extensions won't break existing platforms.
>> 
>> IPI related stuff are pulled to asm/ipi.h to avoid include
>> linux/interrupt.h in asm/smp.h.
>> 
>> Signed-off-by: Jiaxun Yang <jiaxun.yang@...goat.com>
>> ---
>>  arch/mips/cavium-octeon/smp.c   | 109 ++++++++++++-----------------------
>>  arch/mips/include/asm/ipi.h     |  34 +++++++++++
>>  arch/mips/include/asm/smp-ops.h |   8 +--
>>  arch/mips/include/asm/smp.h     |  42 ++++++--------
>>  arch/mips/kernel/smp-bmips.c    |  43 +++++++-------
>>  arch/mips/kernel/smp-cps.c      |   1 +
>>  arch/mips/kernel/smp.c          | 124 ++++++++++++++++++++--------------------
>>  arch/mips/loongson64/smp.c      |  51 +++++++++--------
>>  arch/mips/mm/c-octeon.c         |   2 +-
>>  arch/mips/sgi-ip27/ip27-smp.c   |  15 +++--
>>  arch/mips/sgi-ip30/ip30-smp.c   |  15 +++--
>>  arch/mips/sibyte/bcm1480/smp.c  |  19 +++---
>>  arch/mips/sibyte/sb1250/smp.c   |  13 +++--
>>  13 files changed, 236 insertions(+), 240 deletions(-)
>
> you are touching a lot of platforms, how many did you test ?

As mentioned in cover letter:

```
It has been tested on MIPS Boston I6500, malta SOC-It, Loongson-2K,
Cavium CN7130 (EdgeRouter 4), and an unannounced interaptiv UP MT
platform with EIC.

I don't really know broadcom platforms and SGI platforms well so
changes to those platforms are kept minimal (no functional change).
```

Thanks
- Jiaxun

>
> Thomas.
>
> -- 
> Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
> good idea.                                                [ RFC1925, 2.3 ]

-- 
- Jiaxun