linux-kernel - RE: [PATCH v5 3/6] dt-bindings: iio: dac: Generalize DAC common properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: 
 <PH0PR03MB7141C47BF2CB619B2097FD95F9DD2@PH0PR03MB7141.namprd03.prod.outlook.com>
Date: Wed, 3 Jul 2024 05:11:39 +0000
From: "Paller, Kim Seer" <KimSeer.Paller@...log.com>
To: Conor Dooley <conor@...nel.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Jonathan Cameron
	<jic23@...nel.org>,
        David Lechner <dlechner@...libre.com>,
        Lars-Peter Clausen
	<lars@...afoo.de>,
        Liam Girdwood <lgirdwood@...il.com>, Mark Brown
	<broonie@...nel.org>,
        Dimitri Fedrau <dima.fedrau@...il.com>,
        Krzysztof
 Kozlowski <krzk+dt@...nel.org>,
        Rob Herring <robh@...nel.org>, Conor Dooley
	<conor+dt@...nel.org>,
        "Hennerich, Michael" <Michael.Hennerich@...log.com>,
        Nuno Sá <noname.nuno@...il.com>
Subject: RE: [PATCH v5 3/6] dt-bindings: iio: dac: Generalize DAC common
 properties



> -----Original Message-----
> From: Conor Dooley <conor@...nel.org>
> Sent: Tuesday, July 2, 2024 11:30 PM
> To: Paller, Kim Seer <KimSeer.Paller@...log.com>
> Cc: linux-kernel@...r.kernel.org; linux-iio@...r.kernel.org;
> devicetree@...r.kernel.org; Jonathan Cameron <jic23@...nel.org>; David
> Lechner <dlechner@...libre.com>; Lars-Peter Clausen <lars@...afoo.de>;
> Liam Girdwood <lgirdwood@...il.com>; Mark Brown <broonie@...nel.org>;
> Dimitri Fedrau <dima.fedrau@...il.com>; Krzysztof Kozlowski
> <krzk+dt@...nel.org>; Rob Herring <robh@...nel.org>; Conor Dooley
> <conor+dt@...nel.org>; Hennerich, Michael
> <Michael.Hennerich@...log.com>; Nuno Sá <noname.nuno@...il.com>
> Subject: Re: [PATCH v5 3/6] dt-bindings: iio: dac: Generalize DAC common
> properties
> 
> [External]
> 
> On Tue, Jul 02, 2024 at 11:00:22AM +0800, Kim Seer Paller wrote:
> > Introduce a generalized DAC binding that can be used by DACs that have
> > similar properties adding output-range-microamp and output-range-
> microvolt.
> >
> > Signed-off-by: Kim Seer Paller <kimseer.paller@...log.com>
> > ---
> >  .../devicetree/bindings/iio/dac/dac.yaml      | 50 +++++++++++++++++++
> >  1 file changed, 50 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/iio/dac/dac.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/iio/dac/dac.yaml
> > b/Documentation/devicetree/bindings/iio/dac/dac.yaml
> > new file mode 100644
> > index 000000000000..579f52ea6eb1
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/dac/dac.yaml
> > @@ -0,0 +1,50 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/iio/dac/dac.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: IIO Common Properties for DAC Channels
> > +
> > +maintainers:
> > +  - Jonathan Cameron <jic23@...nel.org>
> > +
> > +description:
> > +  A few properties are defined in a common way DAC channels.
> 
> "for DAC channels"
> 
> > +anyOf:
> > +  - oneOf:
> > +      - required:
> > +          - reg
> > +          - output-range-microamp
> > +      - required:
> > +          - reg
> > +          - output-range-microvolt
> > +  - required:
> > +      - reg
> 
> Can't this be more simply written as
> 
> oneOf:
>   - required:
>       - output-range-microamp
>   - required:
>       - output-range-microvolt
> 
> required:
>  - reg
> 
>  ?

I was following the structure used in adc.yaml.
Yes, I think we can simplify it with that.