linux-kernel - Re: [PATCH v3 2/2] xfs: make xfs_log_iovec independent from xfs_log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZoTePWuRKxHXofGF@infradead.org>
Date: Tue, 2 Jul 2024 22:14:37 -0700
From: Christoph Hellwig <hch@...radead.org>
To: Dave Chinner <david@...morbit.com>
Cc: Christoph Hellwig <hch@...radead.org>, alexjlzheng@...il.com,
	chandan.babu@...cle.com, djwong@...nel.org,
	linux-kernel@...r.kernel.org, linux-xfs@...r.kernel.org,
	alexjlzheng@...cent.com
Subject: Re: [PATCH v3 2/2] xfs: make xfs_log_iovec independent from
 xfs_log_vec and free it early

On Wed, Jul 03, 2024 at 09:44:36AM +1000, Dave Chinner wrote:
> Ah, ok, my bad. I missed that because the xfs_log_iovec is not the
> data buffer - it is specifically just the iovec array that indexes
> the data buffer. Everything in the commit message references the
> xfs_log_iovec, and makes no mention of the actual logged metadata
> that is being stored, and I didn't catch that the submitter was
> using xfs_log_iovec to mean something different to what I understand
> it to be from looking at the code. That's why I take the time to
> explain my reasoning - so that people aren't in any doubt about how
> I interpretted the changes and can easily point out where I've gone
> wrong. :) 

And throw in the xfs_log_vec vs xfs_log_iovec naming that keeps
confusing me after all these years..