linux-kernel - Re: linux-next: Signed-off-by missing for commit in the v4l-dvb-next tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b47f96bb-b1a5-48a1-8002-1cee351bdb3f@xs4all.nl>
Date: Wed, 3 Jul 2024 11:17:47 +0200
From: Hans Verkuil <hverkuil-cisco@...all.nl>
To: Stephen Rothwell <sfr@...b.auug.org.au>,
 Mauro Carvalho Chehab <mchehab@...nel.org>
Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
 Linux Next Mailing List <linux-next@...r.kernel.org>,
 Linux Media Mailing List <linux-media@...r.kernel.org>
Subject: Re: linux-next: Signed-off-by missing for commit in the v4l-dvb-next
 tree

Hi Stephen,

On 03/07/2024 08:33, Stephen Rothwell wrote:
> Hi all,
> 
> Commit
> 
>   57dd8f2f77bc ("Revert "media: stm32: dcmipp: correct error handling in dcmipp_create_subdevs"")
> 
> is missing a Signed-off-by from its author and committer.
> 
> Reverts are commits as well.
> 

My mistake. I discovered that git revert doesn't run the commit-msg hook.

Anyway, I installed a pre-push hook to double check this before I push to
our tree, so hopefully this won't happen again.

Question: does this have to be fixed? That would require a rebase, I think,
which makes some media developers unhappy. Or can this be left as-is for one
time?

Regards,

	Hans