linux-kernel - Re: linux-next: Signed-off-by missing for commit in the v4l-dvb-next tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240703213527.221bfe5a@canb.auug.org.au>
Date: Wed, 3 Jul 2024 21:35:27 +1000
From: Stephen Rothwell <sfr@...b.auug.org.au>
To: Hans Verkuil <hverkuil-cisco@...all.nl>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>, Linux Kernel Mailing List
 <linux-kernel@...r.kernel.org>, Linux Next Mailing List
 <linux-next@...r.kernel.org>, Linux Media Mailing List
 <linux-media@...r.kernel.org>
Subject: Re: linux-next: Signed-off-by missing for commit in the
 v4l-dvb-next tree

Hi Hans,

On Wed, 3 Jul 2024 11:17:47 +0200 Hans Verkuil <hverkuil-cisco@...all.nl> wrote:
>
> My mistake. I discovered that git revert doesn't run the commit-msg hook.

Interesting to know.

> Anyway, I installed a pre-push hook to double check this before I push to
> our tree, so hopefully this won't happen again.

Nice idea.

> Question: does this have to be fixed? That would require a rebase, I think,
> which makes some media developers unhappy. Or can this be left as-is for one
> time?

A one off probably doesn't matter (especially such a small patch).

I have to admit though, it looks like this revert *introduces* an
infinite loop i.e. what decrements i?
-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped