linux-kernel - Re: [PATCH 1/3] scsi: sd: disable discard when set target full provisioning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq18qyjciuj.fsf@ca-mkp.ca.oracle.com>
Date: Tue, 02 Jul 2024 22:31:07 -0400
From: "Martin K. Petersen" <martin.petersen@...cle.com>
To: Haoqian He <haoqian.he@...rtx.com>
Cc: Christoph Hellwig <hch@...radead.org>,
        "James E.J. Bottomley"
 <James.Bottomley@...senPartnership.com>,
        linux-kernel@...r.kernel.org (open list),
        linux-scsi@...r.kernel.org (open list:SCSI SUBSYSTEM),
        "Martin K. Petersen" <martin.petersen@...cle.com>, fengli@...rtx.com
Subject: Re: [PATCH 1/3] scsi: sd: disable discard when set target full
 provisioning


Haoqian,

> +	if (!sdkp->lbpvpd)
> +		/* Disable discard if LBP VPD page not provided */
> +		return SD_LBP_DISABLE;

That is not a valid assumption. Many devices which support thin
provisioning either predate the LBP VPD being defined or have decided
not to support that page. The current heuristics are very deliberate.

-- 
Martin K. Petersen	Oracle Linux Engineering