linux-kernel - Re: [PATCH 3/3] scsi: sd: remove some redundant initialization code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <344C3711-EE11-41F8-975A-EEA312CCD833@smartx.com>
Date: Thu, 4 Jul 2024 11:01:38 +0800
From: Haoqian He <haoqian.he@...rtx.com>
To: Damien Le Moal <dlemoal@...nel.org>
Cc: Christoph Hellwig <hch@...radead.org>,
 "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
 open list <linux-kernel@...r.kernel.org>,
 "open list:SCSI SUBSYSTEM" <linux-scsi@...r.kernel.org>,
 "Martin K. Petersen" <martin.petersen@...cle.com>,
 Li Feng <fengli@...rtx.com>
Subject: Re: [PATCH 3/3] scsi: sd: remove some redundant initialization code

> 2024年7月2日 11:33，Damien Le Moal <dlemoal@...nel.org> 写道：
> 
> On 7/2/24 12:01, Haoqian He wrote:
>> Since the memory allocated by kzalloc for sdkp has been
>> initialized to 0, the code that initializes some sdkp
>> fields to 0 is no longer needed.
>> 
>> Signed-off-by: Haoqian He <haoqian.he@...rtx.com>
>> Signed-off-by: Li Feng <fengli@...rtx.com>
> 
> Looks OK to me.
> 
> Reviewed-by: Damien Le Moal <dlemoal@...nel.org>
> 
> -- 
> Damien Le Moal
> Western Digital Research
> 

Hi Martin,

According to the SBC-3 SPEC:
"The device server in a logical unit that supports logical block provisioning
management shall set the LBPME bit to one in the parameter data returned for
a READ CAPACITY (16) command."

So we can use lbpme bit instead of lbpvpd to indicate if the device is thin
provisioned, which was implemented in patch 2 ("scsi: sd: remove scsi_disk
field lbpvpd").

Thanks,
Haoqian