linux-kernel - Re: [PATCH v1 2/2] drm/panel: jd9365da: Support for Melfas lmfbx101117480 MIPI-DSI panel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHwB_N+Gr=Kso6=UabHseB0UTb+4wWpHR5MAZ82bHe5At_y-cw@mail.gmail.com>
Date: Thu, 4 Jul 2024 12:36:40 +0800
From: cong yang <yangcong5@...qin.corp-partner.google.com>
To: Linus Walleij <linus.walleij@...aro.org>
Cc: sam@...nborg.org, neil.armstrong@...aro.org, daniel@...ll.ch, 
	dianders@...omium.org, swboyd@...omium.org, airlied@...il.com, 
	dmitry.baryshkov@...aro.org, krzysztof.kozlowski+dt@...aro.org, 
	robh+dt@...nel.org, conor+dt@...nel.org, 
	lvzhaoxiong@...qin.corp-partner.google.com, dri-devel@...ts.freedesktop.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 2/2] drm/panel: jd9365da: Support for Melfas
 lmfbx101117480 MIPI-DSI panel

Hi,

Linus Walleij <linus.walleij@...aro.org> 于2024年7月3日周三 21:10写道：
>
> On Tue, Jul 2, 2024 at 3:02 PM Cong Yang
> <yangcong5@...qin.corp-partner.google.com> wrote:
>
> > The Melfas lmfbx101117480 is a 10.1" WXGA TFT-LCD panel, use jd9365da
> > controller, which fits in nicely with the existing panel-jadard-jd9365da-h3
> > driver. Hence, we add a new compatible with panel specific config.
> >
> > Signed-off-by: Cong Yang <yangcong5@...qin.corp-partner.google.com>
>
> This is certainly OK
> Acked-by: Linus Walleij <linus.walleij@...aro.org>
>
> > +static int melfas_lmfbx101117480_init_cmds(struct jadard *jadard)
> > +{
> > +       struct mipi_dsi_multi_context dsi_ctx = { .dsi = jadard->dsi };
> > +
> > +       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xe0, 0x00);
> > +       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xe1, 0x93);
> > +       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xe2, 0x65);
> > +       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xe3, 0xf8);
> > +       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x80, 0x03);
> > +       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xe0, 0x01);
>
> Until this point *all* displays have the same init sequence, what about
> a follow-up patch that start to break things that are always the
> same into helper functions?
>
> These sequences all have a lot of the same magic bytes, so if
> you guys have a datasheet for this display controller then start
> adding gradually some #defines for the e0, e1, e2 etc commands
> please.

Okay, will add a patch in V2 series to fix it. Thanks.

>
> Yours,
> Linus Walleij