linux-kernel - Re: [PATCH 2/4] cpufreq: loongson2: Remove empty exit() callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAhV-H7S5jruSvkt6PcuChxNEbuZQ=75Oj6VSgSvDqeydGvFLw@mail.gmail.com>
Date: Thu, 4 Jul 2024 17:36:49 +0800
From: Huacai Chen <chenhuacai@...nel.org>
To: Viresh Kumar <viresh.kumar@...aro.org>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, Jiaxun Yang <jiaxun.yang@...goat.com>, linux-pm@...r.kernel.org, 
	Vincent Guittot <vincent.guittot@...aro.org>, linux-mips@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] cpufreq: loongson2: Remove empty exit() callback

Reviewed-by: Huacai Chen <chenhuacai@...ngson.cn>

On Thu, Jul 4, 2024 at 2:56 PM Viresh Kumar <viresh.kumar@...aro.org> wrote:
>
> The exit() callback is optional, remove the empty one.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>
> ---
>  drivers/cpufreq/loongson2_cpufreq.c | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/drivers/cpufreq/loongson2_cpufreq.c b/drivers/cpufreq/loongson2_cpufreq.c
> index afc59b292153..6a8e97896d38 100644
> --- a/drivers/cpufreq/loongson2_cpufreq.c
> +++ b/drivers/cpufreq/loongson2_cpufreq.c
> @@ -85,18 +85,12 @@ static int loongson2_cpufreq_cpu_init(struct cpufreq_policy *policy)
>         return 0;
>  }
>
> -static int loongson2_cpufreq_exit(struct cpufreq_policy *policy)
> -{
> -       return 0;
> -}
> -
>  static struct cpufreq_driver loongson2_cpufreq_driver = {
>         .name = "loongson2",
>         .init = loongson2_cpufreq_cpu_init,
>         .verify = cpufreq_generic_frequency_table_verify,
>         .target_index = loongson2_cpufreq_target,
>         .get = cpufreq_generic_get,
> -       .exit = loongson2_cpufreq_exit,
>         .attr = cpufreq_generic_attr,
>  };
>
> --
> 2.31.1.272.g89b43f80a514
>
>