linux-kernel - Re: [PATCH 4/4] drm/panic: Add a qr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH5fLghobuv39Pv5gUrieridzHg5ouAESCOdXGWcjAe=yx1U+A@mail.gmail.com>
Date: Thu, 4 Jul 2024 11:37:55 +0200
From: Alice Ryhl <aliceryhl@...gle.com>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: jfalempe@...hat.com, a.hindborg@...sung.com, airlied@...il.com, 
	alex.gaynor@...il.com, benno.lossin@...ton.me, bjorn3_gh@...tonmail.com, 
	boqun.feng@...il.com, dakr@...hat.com, daniel@...ll.ch, 
	dri-devel@...ts.freedesktop.org, gary@...yguo.net, 
	linux-kernel@...r.kernel.org, maarten.lankhorst@...ux.intel.com, 
	mripard@...nel.org, ojeda@...nel.org, rust-for-linux@...r.kernel.org, 
	tzimmermann@...e.de, wedsonaf@...il.com
Subject: Re: [PATCH 4/4] drm/panic: Add a qr_code panic screen

On Thu, Jul 4, 2024 at 11:28 AM Greg KH <gregkh@...uxfoundation.org> wrote:
>
> On Thu, Jul 04, 2024 at 09:11:09AM +0000, Alice Ryhl wrote:
> > As long as the above requirements are satisfied, calling
> > `drm_panic_qr_generate` should never cause memory unsafety, so this is
> > an appropriate list of safety requirements.
> >
> > (You also require that `data_len <= data_size`, but if this is violated
> > you get a kernel panic which isn't a memory safety problem, so it does
> > not need to be listed in the safety requirements.)
>
> Panicing while trying to print out a panic message is not a good idea,
> so enforcing this would be nice :)

I guess it would make sense to have an if that verifies that `data_len
<= data_size` at the top of drm_panic_qr_generate.

Alice