linux-kernel - Re: [PATCH 0/3] Address !chip->auth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87v81lia1d.fsf@mail.lhotse>
Date: Thu, 04 Jul 2024 23:03:42 +1000
From: Michael Ellerman <mpe@...erman.id.au>
To: Jarkko Sakkinen <jarkko@...nel.org>, Jarkko Sakkinen
 <jarkko@...nel.org>, linux-integrity@...r.kernel.org
Cc: James Bottomley <James.Bottomley@...senPartnership.com>, Mimi Zohar
 <zohar@...ux.ibm.com>, David Howells <dhowells@...hat.com>, Paul Moore
 <paul@...l-moore.com>, James Morris <jmorris@...ei.org>, "Serge E.
 Hallyn" <serge@...lyn.com>, keyrings@...r.kernel.org,
 linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org, Linus
 Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH 0/3] Address !chip->auth

"Jarkko Sakkinen" <jarkko@...nel.org> writes:
> On Wed Jul 3, 2024 at 8:08 PM EEST, Jarkko Sakkinen wrote:
>> Tested on x86-64 with:
>>
>> - TCG_TPM2_HMAC disabled.
>> - TCG_TPM2_HMAC enabled.
>> - TCG_TPM2_HMAC enabled, and "/* rc = tpm2_sessions_init(chip); */".
>>
>> Jarkko Sakkinen (3):
>>   tpm: Address !chip->auth in tpm2_*_auth_session()
>>   tpm: Address !chip->auth in tpm_buf_append_name()
>>   tpm: Address !chip->auth in tpm_buf_append_hmac_session*()
>>
>>  drivers/char/tpm/Makefile        |   2 +-
>>  drivers/char/tpm/tpm2-sessions.c | 400 +++++++++++++++++--------------
>>  include/linux/tpm.h              |  75 ++----
>>  3 files changed, 245 insertions(+), 232 deletions(-)
>
> Aiming these still to 6.10 so that there would not be known regressions
> in hmac authenticated sessions. Note that issue is wider than "just"
> tpm_ibmvtpm.

This seems OK on my PowerVM box using tpm_ibmvtpm and TCG_TPM2_HMAC=y.
I do see one new message:

  [    2.475208] tpm2_start_auth_session: encryption is not active

But no error messages like on mainline.

Tested-by: Michael Ellerman <mpe@...erman.id.au> (powerpc)

cheers