linux-kernel - Re: [PATCH] gpu: ipu-v3: Removal of of_node_put with _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20240704132617.1003914-1-jain.abhinav177@gmail.com>
Date: Thu,  4 Jul 2024 13:26:17 +0000
From: Abhinav Jain <jain.abhinav177@...il.com>
To: javier.carrasco.cruz@...il.com
Cc: airlied@...il.com,
	daniel@...ll.ch,
	dri-devel@...ts.freedesktop.org,
	jain.abhinav177@...il.com,
	julia.lawall@...ia.fr,
	linux-kernel@...r.kernel.org,
	p.zabel@...gutronix.de,
	skhan@...uxfoundation.org
Subject: Re: [PATCH] gpu: ipu-v3: Removal of of_node_put with __free for auto cleanup

On Tue, 2 Jul 2024 17:29:14 +0200, Javier Carrasco wrote:
> Hi Abhinav,
>
> Apart form having sent two different patches with the same title (hence
> the confusion), this cleanup is right from a functional point of view.
>
> On the other hand, the description should address why you are doing this
> cleanup (e.g. to remove the need for explicit of_node_put() when the
> variable goes out of scope). The need for of_node_put() does no vanish,
> it is only automated and no longer visible at first glance by means of
> the cleanup attribute.
>
> Best regards,
> Javier Carrasco

Hi Javier,

Thank you for the detailed feedback. I have modified the patch subject as
well as the commit description to better fit the cleanup task being done.

PATCH v2:
https://lore.kernel.org/all/20240704132142.1003887-1-jain.abhinav177@gmail.com/

Best Regards,
Abhinav Jain