[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <23da6ae19d3cc17b445b77e18e2ac98c490f9b7b.camel@gmail.com>
Date: Fri, 05 Jul 2024 13:58:05 -0700
From: Eduard Zingerman <eddyz87@...il.com>
To: Benjamin Tissoires <bentiss@...nel.org>, Alexei Starovoitov
<ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, Andrii Nakryiko
<andrii@...nel.org>, Martin KaFai Lau <martin.lau@...ux.dev>, Song Liu
<song@...nel.org>, Yonghong Song <yonghong.song@...ux.dev>, John Fastabend
<john.fastabend@...il.com>, KP Singh <kpsingh@...nel.org>, Stanislav
Fomichev <sdf@...gle.com>, Hao Luo <haoluo@...gle.com>, Jiri Olsa
<jolsa@...nel.org>, Mykola Lysenko <mykolal@...com>, Shuah Khan
<shuah@...nel.org>
Cc: bpf@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-kselftest@...r.kernel.org
Subject: Re: [PATCH bpf-next 1/2] bpf: helpers: fix bpf_wq_set_callback_impl
signature
On Fri, 2024-07-05 at 15:44 +0200, Benjamin Tissoires wrote:
> I realized this while having a map containing both a struct bpf_timer and
> a struct bpf_wq: the third argument provided to the bpf_wq callback is
> not the struct bpf_wq pointer itself, but the pointer to the value in
> the map.
>
> Which means that the users need to double cast the provided "value" as
> this is not a struct bpf_wq *.
>
> This is a change of API, but there doesn't seem to be much users of bpf_wq
> right now, so we should be able to go with this right now.
>
> Fixes: 81f1d7a583fa ("bpf: wq: add bpf_wq_set_callback_impl")
> Signed-off-by: Benjamin Tissoires <bentiss@...nel.org>
> ---
Reviewed-by: Eduard Zingerman <eddyz87@...il.com>
Powered by blists - more mailing lists