linux-kernel - Re: [PATCH v9 06/10] iomap: fix iomap_dio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240705141911.zamclkk7iajcvwik@quentin>
Date: Fri, 5 Jul 2024 14:19:11 +0000
From: "Pankaj Raghav (Samsung)" <kernel@...kajraghav.com>
To: Hannes Reinecke <hare@...e.de>
Cc: Dave Chinner <david@...morbit.com>, willy@...radead.org,
	chandan.babu@...cle.com, djwong@...nel.org, brauner@...nel.org,
	akpm@...ux-foundation.org, yang@...amperecomputing.com,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	john.g.garry@...cle.com, linux-fsdevel@...r.kernel.org,
	p.raghav@...sung.com, mcgrof@...nel.org, gost.dev@...sung.com,
	cl@...amperecomputing.com, linux-xfs@...r.kernel.org, hch@....de,
	Zi Yan <ziy@...dia.com>
Subject: Re: [PATCH v9 06/10] iomap: fix iomap_dio_zero() for fs bs > system
 page size

> > > 
> > > There are other users of ZERO_PAGE, most notably in fs/direct-io.c and
> > > block/blk-lib.c. Any chance to make this available to them?
> > 
> > Please, no.
> > 
> > We need to stop feature creeping this patchset and bring it to a
> > close. If changing code entirely unrelated to this patchset is
> > desired, please do it as a separate independent set of patches.
> > 
> Agree; it was a suggestion only.

I was going to say the same thing that Dave said as well as we are 
almost there with this series :)

But I will add your suggestion in my TODO. It would be good to have some
common infra to avoid allocating larger zero pages all over the place.

> 
> Pankaj, you can add my:
> 
> Reviewed-by: Hannes Reinecke <hare@...e.de>

Thanks Hannes.