linux-kernel - Re: [PATCH] mtd: rawnand: lpx32xx: Fix dma_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e3dc918e-07df-4fd1-b69a-9650a246ff7c@web.de>
Date: Fri, 5 Jul 2024 17:26:15 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Piotr Wojtaszczyk <piotr.wojtaszczyk@...esys.com>,
 linux-mtd@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org,
 Arnd Bergmann <arnd@...db.de>, Dan Carpenter <dan.carpenter@...aro.org>,
 Miquel Raynal <miquel.raynal@...tlin.com>,
 Richard Weinberger <richard@....at>, Vignesh Raghavendra <vigneshr@...com>,
 Vladimir Zapolskiy <vz@...ia.com>
Cc: LKML <linux-kernel@...r.kernel.org>, Li Zetao <lizetao1@...wei.com>,
 Yangtao Li <frank.li@...o.com>
Subject: Re: [PATCH] mtd: rawnand: lpx32xx: Fix dma_request_chan() error
 checks

…
> dma_request_channel() returns NULL in case of error …

* I find this information not relevant here because such a function
  is not called at the affected source code places.

* Please improve such a change description with imperative wordings.
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc6#n94

> Fixes: 7326d3fb1ee3 ("mtd: rawnand: lpx32xx: Request DMA channels
> using DT entries")

Please omit a line break from the tag summary.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc6#n145

Regards,
Markus