linux-kernel - Re: [PATCH] USB: core: add 'shutdown' callback to usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <C5231A8D-C529-4BAC-9E2D-32F00321A294@live.com>
Date: Sat, 6 Jul 2024 08:56:05 +0000
From: Aditya Garg <gargaditya08@...e.com>
To: "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC: "oneukum@...e.com" <oneukum@...e.com>, "stern@...land.harvard.edu"
	<stern@...land.harvard.edu>, "linux-usb@...r.kernel.org"
	<linux-usb@...r.kernel.org>, Linux Kernel Mailing List
	<linux-kernel@...r.kernel.org>, "linux-scsi@...r.kernel.org"
	<linux-scsi@...r.kernel.org>, "usb-storage@...ts.one-eyed-alien.net"
	<usb-storage@...ts.one-eyed-alien.net>, Kerem Karabay <kekrby@...il.com>,
	Orlando Chamberlain <orlandoch.dev@...il.com>
Subject: Re: [PATCH] USB: core: add 'shutdown' callback to usb_driver


Hi Greg

> On 6 Jul 2024, at 1:43 PM, gregkh@...uxfoundation.org wrote:
> 
> On Fri, Jul 05, 2024 at 11:21:06AM +0000, Aditya Garg wrote:
>> From: Kerem Karabay <kekrby@...il.com>
>> 
>> This simplifies running code on shutdown for USB drivers.
>> 
> 
> Sorry, but this does not explain why this is needed at all :(
> 
> Where did this change come from?  What problem does it solve?  Why
> should we take it?
> 

Currently there is no standardized method for USB drivers to handle
shutdown events. This patch simplifies running code on shutdown for USB
devices by adding a shutdown callback to usb_driver. It also implements the
new method to existing "USB Attached SCSI” driver that required shutdown

Is this good enough?
> I think I know the answers to these questions, but you need to document
> it here as to why it is needed (please read the kernel documentation for
> how to write a good changelog text and subject line.)

The subject looks fine to me. If you think it can be improved, suggestions shall be appreciated.

Thanks
Aditya