linux-kernel - Re: [PATCH] USB: core: add 'shutdown' callback to usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024070622-alarm-kissable-f446@gregkh>
Date: Sat, 6 Jul 2024 11:02:18 +0200
From: "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To: Aditya Garg <gargaditya08@...e.com>
Cc: "oneukum@...e.com" <oneukum@...e.com>,
	"stern@...land.harvard.edu" <stern@...land.harvard.edu>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"usb-storage@...ts.one-eyed-alien.net" <usb-storage@...ts.one-eyed-alien.net>,
	Kerem Karabay <kekrby@...il.com>,
	Orlando Chamberlain <orlandoch.dev@...il.com>
Subject: Re: [PATCH] USB: core: add 'shutdown' callback to usb_driver

On Sat, Jul 06, 2024 at 08:56:05AM +0000, Aditya Garg wrote:
> 
> Hi Greg
> 
> > On 6 Jul 2024, at 1:43 PM, gregkh@...uxfoundation.org wrote:
> > 
> > On Fri, Jul 05, 2024 at 11:21:06AM +0000, Aditya Garg wrote:
> >> From: Kerem Karabay <kekrby@...il.com>
> >> 
> >> This simplifies running code on shutdown for USB drivers.
> >> 
> > 
> > Sorry, but this does not explain why this is needed at all :(
> > 
> > Where did this change come from?  What problem does it solve?  Why
> > should we take it?
> > 
> 
> Currently there is no standardized method for USB drivers to handle
> shutdown events. This patch simplifies running code on shutdown for USB
> devices by adding a shutdown callback to usb_driver. It also implements the
> new method to existing "USB Attached SCSI” driver that required shutdown
> 
> Is this good enough?

It's a good start, yes.

But as you say "also" that means you should split this up into at least
2 changes, right?

> > I think I know the answers to these questions, but you need to document
> > it here as to why it is needed (please read the kernel documentation for
> > how to write a good changelog text and subject line.)
> 
> The subject looks fine to me. If you think it can be improved, suggestions shall be appreciated.

When you split the patch up, the subject lines will get better.

thanks,

greg k-h