linux-kernel - Re: [PATCH] ACPI / PMIC: Remove unneeded check in tps68470_pmic_opregion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4ffe1d11-8442-40fc-bb93-581e9d1c93ab@web.de>
Date: Sat, 6 Jul 2024 15:47:02 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Aleksandr Mishin <amishin@...rgos.ru>, linux-acpi@...r.kernel.org,
 lvc-project@...uxtesting.org, Rajmohan Mani <rajmohan.mani@...el.com>,
 Sakari Ailus <sakari.ailus@...ux.intel.com>
Cc: LKML <linux-kernel@...r.kernel.org>, Andy Shevchenko <andy@...nel.org>,
 Len Brown <lenb@...nel.org>,
 Mika Westerberg <mika.westerberg@...ux.intel.com>,
 "Rafael J. Wysocki" <rafael@...nel.org>
Subject: Re: [PATCH] ACPI / PMIC: Remove unneeded check in
 tps68470_pmic_opregion_probe()

> In tps68470_pmic_opregion_probe() pointer 'dev' is compared to NULL which
> is useless.

            because …?

> Fix this issue by removing unneeded check.

Another wording suggestion:
  Thus remove a redundant check (and …?).

…
> +++ b/drivers/acpi/pmic/tps68470_pmic.c
> @@ -376,7 +376,7 @@ static int tps68470_pmic_opregion_probe(struct platform_device *pdev)
>  	struct tps68470_pmic_opregion *opregion;
>  	acpi_status status;
>
> -	if (!dev || !tps68470_regmap) {
> +	if (!tps68470_regmap) {
>  		dev_warn(dev, "dev or regmap is NULL\n");
…

Would you like to adjust the passed string literal accordingly?

Regards,
Markus