linux-kernel - Re: [PATCH-cgroup 1/2] cgroup: Show # of subsystem CSSes in /proc/cgroups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zow4ZJFa6Kwz4BlO@slm.duckdns.org>
Date: Mon, 8 Jul 2024 09:05:08 -1000
From: Tejun Heo <tj@...nel.org>
To: Waiman Long <longman@...hat.com>
Cc: Zefan Li <lizefan.x@...edance.com>,
	Johannes Weiner <hannes@...xchg.org>, cgroups@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH-cgroup 1/2] cgroup: Show # of subsystem CSSes in
 /proc/cgroups

Hello,

On Mon, Jul 08, 2024 at 03:01:39PM -0400, Waiman Long wrote:
> That information is certainly useful to display to cgroup.stat which
> currently only shows nr_descendants and nr_dying_descendants. So does
> "nr_<subsys_name> <cnt>" for each cgroup subsystems look good to you or do
> you have other suggestion?

Yeah, something like that. Johannes, what do you think?

> The reason for this patch is because I got a bug report about leaking blkio
> cgroup due to the information shown in /proc/cgroups. I know you want do
> deprecate it for cgroup v2. How about adding a iine like "# Deprecated for
> cgroup v2, use cgroup.stats file for cgroup counts" at the top of
> /proc/cgroups when cgroup v2 is active?

I wonder whether that would break some parsers but we can try that and see
what happens.

Thanks.

-- 
tejun