linux-kernel - Re: [PATCH RESEND v2 1/2] clk: mediatek: mt8173-infracfg: Handle unallocated infracfg when module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9b455698a33ec5d01c12424ea67c8e88.sboyd@kernel.org>
Date: Mon, 08 Jul 2024 12:05:46 -0700
From: Stephen Boyd <sboyd@...nel.org>
To: Alper Nebi Yasak <alpernebiyasak@...il.com>, AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, linux-mediatek@...ts.infradead.org
Cc: linux-kernel@...r.kernel.org, Rob Herring <robh@...nel.org>, devicetree@...r.kernel.org, Michael Turquette <mturquette@...libre.com>, Uwe Kleine-König <u.kleine-koenig@...gutronix.de>, Conor Dooley <conor+dt@...nel.org>, linux-arm-kernel@...ts.infradead.org, Chen-Yu Tsai <wenst@...omium.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>, linux-clk@...r.kernel.org, Alper Nebi Yasak <alpernebiyasak@...il.com>
Subject: Re: [PATCH RESEND v2 1/2] clk: mediatek: mt8173-infracfg: Handle unallocated infracfg when module

Quoting Alper Nebi Yasak (2024-06-12 13:11:00)
> The MT8173 infracfg clock driver does initialization in two steps, via a
> CLK_OF_DECLARE_DRIVER declaration. However its early init function
> doesn't get to run when it's built as a module, presumably since it's
> not loaded by the time it would have been called by of_clk_init(). This
> causes its second-step probe() to return -ENOMEM when trying to register
> clocks, as the necessary clock_data struct isn't initialized by the
> first step.
> 
> MT2701 and MT6797 clock drivers also use this mechanism, but they try to
> allocate the necessary clock_data structure if missing in the second
> step. Mimic that for the MT8173 infracfg clock as well to make it work
> as a module.
> 
> Signed-off-by: Alper Nebi Yasak <alpernebiyasak@...il.com>
> ---

Applied to clk-next