linux-kernel - Re: [PATCH 01/47] dt-bindings: arm: qcom: Document QCS9100 SoC and RIDE board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f8d17f99-cb76-427a-a23c-6777ab8f4370@kernel.org>
Date: Mon, 8 Jul 2024 09:31:11 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "Aiqun Yu (Maria)" <quic_aiquny@...cinc.com>,
 Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 Tengfei Fan <quic_tengfan@...cinc.com>, andersson@...nel.org,
 konrad.dybcio@...aro.org, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, djakov@...nel.org, mturquette@...libre.com,
 sboyd@...nel.org, jassisinghbrar@...il.com, herbert@...dor.apana.org.au,
 davem@...emloft.net, manivannan.sadhasivam@...aro.org, will@...nel.org,
 joro@...tes.org, conor@...nel.org, tglx@...utronix.de, amitk@...nel.org,
 thara.gopinath@...il.com, linus.walleij@...aro.org, wim@...ux-watchdog.org,
 linux@...ck-us.net, rafael@...nel.org, viresh.kumar@...aro.org,
 vkoul@...nel.org, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
 mcoquelin.stm32@...il.com
Cc: robimarko@...il.com, bartosz.golaszewski@...aro.org, kishon@...nel.org,
 quic_wcheng@...cinc.com, alim.akhtar@...sung.com, avri.altman@....com,
 bvanassche@....org, agross@...nel.org, gregkh@...uxfoundation.org,
 quic_tdas@...cinc.com, robin.murphy@....com, daniel.lezcano@...aro.org,
 rui.zhang@...el.com, lukasz.luba@....com, quic_rjendra@...cinc.com,
 ulf.hansson@...aro.org, quic_sibis@...cinc.com, otto.pflueger@...cue.de,
 luca@...tu.xyz, neil.armstrong@...aro.org, abel.vesa@...aro.org,
 bhupesh.sharma@...aro.org, alexandre.torgue@...s.st.com,
 peppe.cavallaro@...com, joabreu@...opsys.com, netdev@...r.kernel.org,
 lpieralisi@...nel.org, kw@...ux.com, bhelgaas@...gle.com,
 ahalaney@...hat.com, u.kleine-koenig@...gutronix.de,
 dmitry.baryshkov@...aro.org, quic_cang@...cinc.com, danila@...xyga.com,
 quic_nitirawa@...cinc.com, mantas@...vices.com, athierry@...hat.com,
 quic_kbajaj@...cinc.com, quic_bjorande@...cinc.com,
 quic_msarkar@...cinc.com, quic_devipriy@...cinc.com, quic_tsoni@...cinc.com,
 quic_rgottimu@...cinc.com, quic_shashim@...cinc.com,
 quic_kaushalk@...cinc.com, quic_tingweiz@...cinc.com,
 srinivas.kandagatla@...aro.org, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-pm@...r.kernel.org, linux-clk@...r.kernel.org,
 linux-phy@...ts.infradead.org, linux-crypto@...r.kernel.org,
 linux-scsi@...r.kernel.org, linux-usb@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, iommu@...ts.linux.dev,
 linux-riscv@...ts.infradead.org, linux-gpio@...r.kernel.org,
 linux-watchdog@...r.kernel.org, linux-pci@...r.kernel.org,
 linux-stm32@...md-mailman.stormreply.com, kernel@...cinc.com
Subject: Re: [PATCH 01/47] dt-bindings: arm: qcom: Document QCS9100 SoC and
 RIDE board

On 08/07/2024 09:13, Aiqun Yu (Maria) wrote:
> 
> 
> On 7/8/2024 2:07 PM, Krzysztof Kozlowski wrote:
>> On 08/07/2024 06:45, Aiqun Yu (Maria) wrote:
>>>
>>>
>>> On 7/3/2024 5:33 PM, Krzysztof Kozlowski wrote:
>>>> On 03/07/2024 11:21, Tengfei Fan wrote:
>>>>>>>         - items:
>>>>>>>             - enum:
>>>>>>> +              - qcom,qcs9100-ride
>>>>>>>                 - qcom,sa8775p-ride
>>>>>>> +          - const: qcom,qcs9100
>>>>>>
>>>>>> This changes existing compatible for sa8775p without any explanation in
>>>>>> commit msg.
>>>>>>
>>>>>> Best regards,
>>>>>> Krzysztof
>>>>>>
>>>>>
>>>>> In the next verion patch series, I will provide relevant explanatory 
>>>>> information in this patch commit message.
>>>>
>>>> TBH, I cannot think of any reasonable explanation for this, especially
>>>> considering rest of the patchset which does not fix resulting dtbs_check
>>>> warning.
>>>
>>> The existing compatible "sa8775p" warning can only be addressed When
>>> @Nikunj's "sa8775p" changes merged.
>>>
>>> Let me know if you have other suggestions for this.
>>
>> I don't have, because I don't understand why do you want/need to change
>> existing board compatible.
> 
> We can left the current existing sa8775p board compatible as it is. And
> have a brand new qcs9100 and qcs9100-board item for current non-scmi
> resources compatible.
> 
> Will that be more reasonable from your end?

Yes, this is what I would expect. If you choose any other way - just
like I wrote - you need to explain why you are doing this.

Best regards,
Krzysztof