linux-kernel - Re: [PATCH 1/3] dt-bindings: power: Add power sequence for Amloigc WCN chips

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7d109ab0-ebd0-4739-a15e-958e82552a7d@kernel.org>
Date: Mon, 8 Jul 2024 09:32:18 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Yang Li <yang.li@...ogic.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Bartosz Golaszewski <brgl@...ev.pl>
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-pm@...r.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: power: Add power sequence for Amloigc
 WCN chips

On 08/07/2024 08:32, Yang Li wrote:
> 
> 在 2024/7/8 14:11, Krzysztof Kozlowski 写道:
>> [ EXTERNAL EMAIL ]
>>
>> On 08/07/2024 08:04, Yang Li wrote:
>>>>> +
>>>>> +required:
>>>>> +  - compatible
>>>>> +  - clocks
>>>>> +  - clock-names
>>>>> +  - amlogic,chip-enable-gpios
>>>>> +  - amlogic,bt-enable-gpios
>>>>> +
>>>>> +additionalProperties: false
>>>>> +
>>>>> +examples:
>>>>> +  - |
>>>>> +    #include <dt-bindings/gpio/gpio.h>
>>>>> +    wcn_pwrseq {
>>>> No underscores in node names, generic node names.
>>>>
>>>> There is no device as "pwrseq". I also do not get what "wcn" means here.
>>> Yes, I understand.
>>>
>>> Can I change "wcn_pwrseq" to "pmu", and do I need to change the binding
>> What is pmu for your device? What is this device in the first place you
>> are documenting? Where is the datasheet?
> 
> ^_^ Well, You are right, the "pmu" wasn't really fit in here.
> 
> I'd like to explain the current usage first, and could you please give 
> me a suggestion?
> 
> This module(pwrseq) used to power on Bluetooth & Wi-Fi combo chip, both 
> Bluetooth and
> 
> Wi-Fi driver need to control "chip-en-gpios" pins, so we introduced the 
> power sequence module.
> 
> What should we call it in this case?

Sorry, you describe driver, not a device.

That would be a no-go for entire binding. Please describe the hardware,
not what you want to achieve in Linux drivers.


Best regards,
Krzysztof