[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240708113234.GDZovOUgjXFt2XoNg6@fat_crate.local>
Date: Mon, 8 Jul 2024 13:32:34 +0200
From: Borislav Petkov <bp@...en8.de>
To: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Cc: Tony Luck <tony.luck@...el.com>,
Daniel Ferguson <danielf@...amperecomputing.com>,
Ard Biesheuvel <ardb@...nel.org>, James Morse <james.morse@....com>,
Jonathan Cameron <Jonathan.Cameron@...wei.com>,
Len Brown <lenb@...nel.org>,
"Rafael J. Wysocki" <rafael@...nel.org>,
Shiju Jose <shiju.jose@...wei.com>,
Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
Dan Williams <dan.j.williams@...el.com>,
Dave Jiang <dave.jiang@...el.com>, Ira Weiny <ira.weiny@...el.com>,
Shuai Xue <xueshuai@...ux.alibaba.com>, linux-acpi@...r.kernel.org,
linux-edac@...r.kernel.org, linux-efi@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/6] RAS: ACPI: APEI: add conditional compilation to ARM
error report functions
On Mon, Jul 08, 2024 at 01:18:10PM +0200, Mauro Carvalho Chehab wrote:
> From: Daniel Ferguson <danielf@...amperecomputing.com>
>
> This prevents the unnecessary inclusion of ARM specific RAS error
s/This prevents/Prevent/
Avoid having "This patch" or "This commit" or "This does <bla>" in the commit
message. It is tautologically useless.
"Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
to do frotz", as if you are giving orders to the codebase to change
its behaviour."
>From Documentation/process/submitting-patches.rst
> handling routines in non-ARM platforms.
Ok, this does "something". Why does it do it?
Otherwise it won't build on other architectures or is it going to cause code
bloat or why are we doing this?
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
Powered by blists - more mailing lists