linux-kernel - Re: [PATCH 1/6] RAS: ACPI: APEI: add conditional compilation to ARM error report functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240708141025.3e5ddd51@foz.lan>
Date: Mon, 8 Jul 2024 14:10:25 +0200
From: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
To: Borislav Petkov <bp@...en8.de>
Cc: Tony Luck <tony.luck@...el.com>, Daniel Ferguson
 <danielf@...amperecomputing.com>, Ard Biesheuvel <ardb@...nel.org>, James
 Morse <james.morse@....com>, Jonathan Cameron
 <Jonathan.Cameron@...wei.com>, Len Brown <lenb@...nel.org>, "Rafael J.
 Wysocki" <rafael@...nel.org>, Shiju Jose <shiju.jose@...wei.com>, Uwe
 Kleine-König <u.kleine-koenig@...gutronix.de>, Dan
 Williams <dan.j.williams@...el.com>, Dave Jiang <dave.jiang@...el.com>, Ira
 Weiny <ira.weiny@...el.com>, Shuai Xue <xueshuai@...ux.alibaba.com>,
 linux-acpi@...r.kernel.org, linux-edac@...r.kernel.org,
 linux-efi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/6] RAS: ACPI: APEI: add conditional compilation to ARM
 error report functions

Em Mon, 8 Jul 2024 13:32:34 +0200
Borislav Petkov <bp@...en8.de> escreveu:

> On Mon, Jul 08, 2024 at 01:18:10PM +0200, Mauro Carvalho Chehab wrote:
> > From: Daniel Ferguson <danielf@...amperecomputing.com>
> > 
> > This prevents the unnecessary inclusion of ARM specific RAS error  
> 
> s/This prevents/Prevent/
> 
> Avoid having "This patch" or "This commit" or "This does <bla>" in the commit
> message. It is tautologically useless.
> 
> "Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
> instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
> to do frotz", as if you are giving orders to the codebase to change
> its behaviour."
> 
> From Documentation/process/submitting-patches.rst
> 
> > handling routines in non-ARM platforms.  
> 
> Ok, this does "something". Why does it do it?
> 
> Otherwise it won't build on other architectures or is it going to cause code
> bloat or why are we doing this?

Probably a better description would be:

    RAS: ACPI: APEI: add conditional compilation to ARM error report functions

    Don't include ARM Processor specific error handling routines in 
    non-ARM platforms, preparing it to the next patch, as arm-specific
    kAPI symbols will be used, thus avoiding build breakages when ARM
    is not selected.

    [mchehab: avoid unneeded ifdefs and fix coding style issues]
    Signed-off-by: Daniel Ferguson <danielf@...amperecomputing.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>

This patch itself just add conditionals to optimize out code on
non-ARM architectures. The next one will add some ARM-specific bits
inside ARM processor CPER trace, thus causing compilation breakages
on non-ARM, due to arm-specific kAPI bits that will be used then.

Thanks,
Mauro