linux-kernel - Re: [PATCH v2 1/4] Coresight: Add trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <25a195a5-9c05-489b-8ad0-909486c15d25@web.de>
Date: Mon, 8 Jul 2024 14:36:22 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Jie Gan <quic_jiegan@...cinc.com>, coresight@...ts.linaro.org,
 linux-arm-kernel@...ts.infradead.org, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org,
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 James Clark <james.clark@....com>,
 Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 Mathieu Poirier <mathieu.poirier@...aro.org>,
 Mike Leach <mike.leach@...aro.org>, Rob Herring <robh@...nel.org>,
 Suzuki Poulouse <suzuki.poulose@....com>
Cc: LKML <linux-kernel@...r.kernel.org>,
 Jinlong Mao <quic_jinlmao@...cinc.com>, Leo Yan <leo.yan@...aro.org>,
 Song Chai <quic_songchai@...cinc.com>, Tao Zhang <quic_taozha@...cinc.com>,
 Tingwei Zhang <quic_tingweiz@...cinc.com>,
 Trilok Soni <quic_tsoni@...cinc.com>,
 Yuanfang Zhang <quic_yuanfang@...cinc.com>
Subject: Re: [PATCH v2 1/4] Coresight: Add trace_id function to collect trace
 ID

> Add 'trace_id' function pointer in ops. It's responsible for collect the
…

                                          It is?               collecting?


…
> +++ b/drivers/hwtracing/coresight/coresight-etm-perf.c
…
> +	sink_data = kzalloc(sizeof(*sink_data), GFP_KERNEL);
> +	if (!sink_data)
> +		goto fail_end_stop;
…
> +	if (coresight_enable_path(path, CS_MODE_PERF, sink_data)) {
> +		kfree(sink_data);
>  		goto fail_end_stop;
> +	}
…

Would you like to to benefit any more from further applications of scope-based
resource management by using an attribute like “__free(kfree)”?
https://elixir.bootlin.com/linux/v6.10-rc7/source/include/linux/slab.h#L282

Regards,
Markus