linux-kernel - Re: [PATCH v2 3/4] Coresight: Add Coresight Control Unit driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <10cff397-af4f-4649-994f-309203376f42@web.de>
Date: Mon, 8 Jul 2024 14:56:17 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Jie Gan <quic_jiegan@...cinc.com>, coresight@...ts.linaro.org,
 linux-arm-kernel@...ts.infradead.org, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org,
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 James Clark <james.clark@....com>,
 Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 Mathieu Poirier <mathieu.poirier@...aro.org>,
 Mike Leach <mike.leach@...aro.org>, Rob Herring <robh@...nel.org>,
 Suzuki Poulouse <suzuki.poulose@....com>
Cc: LKML <linux-kernel@...r.kernel.org>,
 Jinlong Mao <quic_jinlmao@...cinc.com>, Leo Yan <leo.yan@...aro.org>,
 Song Chai <quic_songchai@...cinc.com>, Tao Zhang <quic_taozha@...cinc.com>,
 Tingwei Zhang <quic_tingweiz@...cinc.com>,
 Trilok Soni <quic_tsoni@...cinc.com>,
 Yuanfang Zhang <quic_yuanfang@...cinc.com>
Subject: Re: [PATCH v2 3/4] Coresight: Add Coresight Control Unit driver

…
> Disabling source device resets the bit according to the source device's trace ID.

How do you think about to improve such a change description with imperative wordings?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc7#n94


…
> +++ b/drivers/hwtracing/coresight/coresight-ccu.c
> @@ -0,0 +1,290 @@
…
> +static int __ccu_set_etr_traceid(struct coresight_device *csdev,
> +			uint32_t traceid, bool enable)
> +{
…
> +	spin_lock_irqsave(&drvdata->spin_lock, flags);
> +	CS_UNLOCK(drvdata->base);
…
> +	ccu_writel(drvdata, val, reg_offset);
> +
> +	CS_LOCK(drvdata->base);
> +	spin_unlock_irqrestore(&drvdata->spin_lock, flags);
> +	return 0;
> +}
…

Under which circumstances would you become interested to apply a statement
like “guard(spinlock_irqsave)(&drvdata->spin_lock);”?
https://elixir.bootlin.com/linux/v6.10-rc7/source/include/linux/spinlock.h#L574

Regards,
Markus