linux-kernel - Re: [EXT] Re: [PATCH v4 2/5] dt-bindings: arm: fsl: add imx-se-fw binding doc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1036b35a-1d9f-4851-8299-4b42290967d5@kernel.org>
Date: Mon, 8 Jul 2024 14:56:42 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Pankaj Gupta <pankaj.gupta@....com>, Jonathan Corbet <corbet@....net>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Cc: "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
 "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [EXT] Re: [PATCH v4 2/5] dt-bindings: arm: fsl: add imx-se-fw
 binding doc

On 08/07/2024 13:54, Pankaj Gupta wrote:
> 
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@...nel.org>
>> Sent: Monday, July 8, 2024 4:54 PM
>> To: Pankaj Gupta <pankaj.gupta@....com>; Jonathan Corbet
>> <corbet@....net>; Rob Herring <robh@...nel.org>; Krzysztof Kozlowski
>> <krzk+dt@...nel.org>; Conor Dooley <conor+dt@...nel.org>; Shawn Guo
>> <shawnguo@...nel.org>; Sascha Hauer <s.hauer@...gutronix.de>;
>> Pengutronix Kernel Team <kernel@...gutronix.de>; Fabio Estevam
>> <festevam@...il.com>; Rob Herring <robh+dt@...nel.org>; Krzysztof
>> Kozlowski <krzysztof.kozlowski+dt@...aro.org>
>> Cc: linux-doc@...r.kernel.org; linux-kernel@...r.kernel.org;
>> devicetree@...r.kernel.org; imx@...ts.linux.dev; linux-arm-
>> kernel@...ts.infradead.org
>> Subject: Re: [EXT] Re: [PATCH v4 2/5] dt-bindings: arm: fsl: add imx-se-fw
>> binding doc
>>
>> Caution: This is an external email. Please take care when clicking links or
>> opening attachments. When in doubt, report the message using the 'Report
>> this email' button
>>
>>
>> On 08/07/2024 13:19, Pankaj Gupta wrote:
>>>>>> 4 mailboxes? This cannot be different.
>>>>> mbox-names can have any of the above mentioned 4 values.
>>>>> And  two values are minimum, required.
>>>>
>>>> No, I said it cannot be different. If two are minimum, then you can
>>>> have here 4, right? But earlier you said you can have only 2. It does not
>> make any sense.
>>>
>>> Understood.  Will fix this with following changes.
>>>
>>> -      - const: tx
>>> -      - const: rx
>>> -      - const: txdb
>>> -      - const: rxdb
>>> -    minItems: 2
>>> +      - enum:
>>> +          - tx
>>> +          - txdb
>>> +      - enum:
>>> +          - rx
>>> +          - rxdb
>>
>> OK, this is now clear and answer is also clear:
>> No, you cannot have different names, except some rare cases.
>> Please explain why this should be an exception?
> 
> The name suggests the type of protocol for:
> - sending:    tx or txdb (with doorbell).
> - receiving:  rx & rxdb  (with doorbell).
> 
> NXP IP SECO on i.MX8DXL/8QXP supports txdb & rxdb. Hence added these names.
> 
> It is just for readability to understand from platform's DTSI file.

Then no, that's not a reason to break fixed naming rule. These are
supposed to be just tx and rx.

Best regards,
Krzysztof