linux-kernel - Re: [PATCH] HID: mcp2221: Remove unneeded semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240701101204.000065ca@Huawei.com>
Date: Mon, 1 Jul 2024 10:12:04 +0100
From: Jonathan Cameron <Jonathan.Cameron@...wei.com>
To: Chen Ni <nichen@...as.ac.cn>
CC: <gupt21@...il.com>, <jikos@...nel.org>, <bentiss@...nel.org>,
	<matt@...ostay.sg>, <linux-i2c@...r.kernel.org>,
	<linux-input@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] HID: mcp2221: Remove unneeded semicolon

On Mon, 1 Jul 2024 15:16:39 +0800
Chen Ni <nichen@...as.ac.cn> wrote:

> Remove unneeded semicolon.
> This is detected by coccinelle.
> 
> Fixes: 960f9df7c620 ("HID: mcp2221: add ADC/DAC support via iio subsystem")

Fixes tag not appropriate for this one as it's not a bug.

> Signed-off-by: Chen Ni <nichen@...as.ac.cn>
Otherwise looks fine to me.

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>

> ---
>  drivers/hid/hid-mcp2221.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-mcp2221.c b/drivers/hid/hid-mcp2221.c
> index da5ea5a23b08..0f93c22a479f 100644
> --- a/drivers/hid/hid-mcp2221.c
> +++ b/drivers/hid/hid-mcp2221.c
> @@ -1048,7 +1048,7 @@ static int mcp_iio_channels(struct mcp2221 *mcp)
>  			break;
>  		default:
>  			continue;
> -		};
> +		}
>  
>  		chan->type = IIO_VOLTAGE;
>  		chan->indexed = 1;