[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <668d8d2a96bfa_102cc29479@dwillia2-xfh.jf.intel.com.notmuch>
Date: Tue, 9 Jul 2024 12:19:06 -0700
From: Dan Williams <dan.j.williams@...el.com>
To: Alison Schofield <alison.schofield@...el.com>, peng guo
<engguopeng@...a.edu.cn>
CC: <dave@...olabs.net>, <jonathan.cameron@...wei.com>,
<dave.jiang@...el.com>, <vishal.l.verma@...el.com>, <ira.weiny@...el.com>,
<dan.j.williams@...el.com>, <linux-cxl@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <wyguopeng@....com>
Subject: Re: [PATCH v2] cxl/core: Fix the UUID of CXL vendor debug Log
identifier
Alison Schofield wrote:
> On Tue, Jul 09, 2024 at 10:12:39PM +0800, peng guo wrote:
> > Fix the definition value of DEFINE_CXL_VENDOR_DEBUG_UUID to match the
> > CXL r3.1 specification, although this value is not currently used.
>
> I thought the value was actually used.
> Please help me understand by responding to v1 review:
> https://lore.kernel.org/Zow0Aw+vrXShXv+n@aschofie-mobl2/
I assume that this was some "by inspection" reason for the "how found".
This effectively proves that no one has ever tried to use
CXL_MEM_COMMAND_ID_CLEAR_LOG with the vendor debug log. It could be the
case that everyone to date that ever had that need is just using RAW
commands to do it.
To me this is another example of Linux command wrapping CXL command
failure.
To your point though, it would be good to get that user visible effect
into the changelog so that distros can decide about the impact of
backporting this fix.
Powered by blists - more mailing lists